You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe that envelopes should be abstract and have all their methods be final : that would allow for removing the DesignForExtensionCheck suppression from checkstyle. It exists for good reasons, it is dangerous to use inheritance, but it is way safer when one can't override inherited behaviour.
Also it should be abstract because as a good rule, classes should be either final or abstract to avoid confusing situation with inheritance.
The text was updated successfully, but these errors were encountered:
I see XmlWriterWrap was introduced in #109.
I believe that envelopes should be abstract and have all their methods be final : that would allow for removing the
DesignForExtensionCheck
suppression from checkstyle. It exists for good reasons, it is dangerous to use inheritance, but it is way safer when one can't override inherited behaviour.Also it should be abstract because as a good rule, classes should be either final or abstract to avoid confusing situation with inheritance.
The text was updated successfully, but these errors were encountered: