Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect data-bind string format breaks in very cryptic way #55

Closed
tristanls opened this issue Oct 18, 2011 · 2 comments
Closed

Incorrect data-bind string format breaks in very cryptic way #55

tristanls opened this issue Oct 18, 2011 · 2 comments
Assignees
@tristanls
Labels
bug

Comments

@tristanls
Copy link
Collaborator

If someone writes

< select data-bind="id id, value" >

It will break with unhelpful Uncaught agility.js: unknown argument for getter error message. It would be quite difficult to figure out that the correction is

< select data-bind="value, id id">
@ghost ghost assigned tristanls Oct 18, 2011
@tlack
Copy link
Collaborator

tlack commented Dec 15, 2011

Perhaps making the data-bind format look like "value,class=itemClass" rather than "value,class itemClass" would make it easier to visually recognize and detect these errors inside agility.js itself?

@tristanls tristanls mentioned this issue Dec 16, 2011
Merged
arturadib added a commit that referenced this issue Jan 9, 2012
@arturadib
Merge pull request #65 from tristanls/master
a2486c8 
Implemented fix for #55, accept data-bind variables/attributes in any order
@tristanls
Copy link
Collaborator Author

Fixed in #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tristanls tristanls

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tlack @tristanls