Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function for validating a found issue #45

Open
3 tasks
andreaskern74 opened this issue Oct 4, 2024 · 0 comments
Open
3 tasks

Function for validating a found issue #45

andreaskern74 opened this issue Oct 4, 2024 · 0 comments
Labels
effort:Medium isState:New A new issue that needs to be classified to a type. isType:Feature An issue that adds new features to the project.
Milestone

Comments

@andreaskern74
Copy link
Contributor

andreaskern74 commented Oct 4, 2024

Is your feature request related to a problem? Please describe.

Even our own implementation has some errors in the result file. Example:
image

The reason is that the implementation of the check does not set the description of the <Locations description=""> element (line 2):

<Issue issueId="0" description="Redudant elevation declaration." level="2" ruleUID="asam.net:xodr:1.7.0:performance.avoid_redundant_info">
  <Locations description="">
    <XMLLocation xpath="/OpenDRIVE/road[2]"/>
  </Locations>
  <Locations description="Redudant elevation declaration.">
    <InertialLocation x="338.7385111691241" y="179.2506648601534" z="0.0"/>
  </Locations>
</Issue>

Describe the solution you'd like

There should be a function available, which validates the information, which cannot be validated by a simple XSD check.

A first validation step is to check that there are no empty fields. There might be much more possibilities, e.g. validate the xpath. We had the issue that somebody created an unresolvable xpath.

This function:

  • Can be included in own tests when validating result files from the C++ base library (or other implementations)
  • Shall be included in all the regression tests of the ASAM product

List of things that can be checked

  • Non-empty fields (e.g. description)
  • XPath can be resolved
  • FileLocation is valid
@andreaskern74 andreaskern74 added isType:Feature An issue that adds new features to the project. isState:New A new issue that needs to be classified to a type. labels Oct 4, 2024
@andreaskern74 andreaskern74 added this to the Wish List milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort:Medium isState:New A new issue that needs to be classified to a type. isType:Feature An issue that adds new features to the project.
Projects
None yet
Development

No branches or pull requests

1 participant