Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The options page should pass the options to the refreshOptions function #404

Open
ggrossetie opened this issue Jul 21, 2020 · 0 comments
Open

The options page should pass the options to the refreshOptions function #404

ggrossetie opened this issue Jul 21, 2020 · 0 comments
Labels
🍩 enhancement 🧭 Safari

Comments

@ggrossetie
Copy link
Member

Currently, we rely on a global variable localStorage shared between the option page context and the background page context:

asciidoctor-browser-extension/app/js/options.js

Line 71 in da9a3c4

webExtension.runtime.getBackgroundPage((page) => page.refreshOptions())

In Safari, the option page and background page are isolated so we should not rely on this variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🍩 enhancement 🧭 Safari
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ggrossetie