diff --git a/microsoft-integration/impl/src/main/java/org/sakaiproject/microsoft/impl/MicrosoftCommonServiceImpl.java b/microsoft-integration/impl/src/main/java/org/sakaiproject/microsoft/impl/MicrosoftCommonServiceImpl.java index d43adfae29f..2598e1d8a72 100644 --- a/microsoft-integration/impl/src/main/java/org/sakaiproject/microsoft/impl/MicrosoftCommonServiceImpl.java +++ b/microsoft-integration/impl/src/main/java/org/sakaiproject/microsoft/impl/MicrosoftCommonServiceImpl.java @@ -1035,7 +1035,7 @@ public boolean addMemberToTeam(String userId, String teamId) throws MicrosoftCre } catch (MicrosoftCredentialsException e) { throw e; } catch (Exception e) { - log.debug("Error adding owner userId={} to teamId={}", userId, teamId); + log.debug("Error adding member userId={} to teamId={}", userId, teamId); return false; } return true; @@ -1109,6 +1109,8 @@ public SynchronizationStatus addUsersToTeamOrGroup(String teamId, List add to channel - //IMPORTANT: all non-existent users in Site, have been invited. So, should be no users in Group that do not exist in Microsoft - //IMPORTANT 2: if user is just added to a group (because is guest/invited), maybe can not be added immediately to a channel - if (!addMemberToMicrosoftChannel(ss, gs, mu) && !ret.equals(SynchronizationStatus.ERROR)) { - ret = SynchronizationStatus.ERROR_GUEST; - } } } ret = microsoftCommonService.addUsersToChannel(ss, gs, members, ret, new LinkedList<>()); @@ -1004,12 +998,6 @@ private SynchronizationStatus runGroupSynchronization(SiteSynchronization ss, Gr if (mu != null) { owners.add(mu); - //user exists -> add to channel - //IMPORTANT: all non-existent users in Site, have been invited. So, there are no users in Group that do not exist in Microsoft - //IMPORTANT 2: if user is just added to a group (because is guest/invited), maybe can not be added immediately to a channel - if (!addOwnerToMicrosoftChannel(ss, gs, mu) && !ret.equals(SynchronizationStatus.ERROR)) { - ret = SynchronizationStatus.ERROR_GUEST; - } } }