Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWA Name #17

Closed
lhunath opened this issue Mar 6, 2021 · 1 comment
Closed

PWA Name #17

lhunath opened this issue Mar 6, 2021 · 1 comment

Comments

@lhunath
Copy link
Contributor

lhunath commented Mar 6, 2021

Currently, the extension uses the forum's title as the "short name", ie. the name that appears as the app name.

This is fine as a default, but not fine as a general hard rule. App names are generally very constrained strings and their usage is not in the least bit compatible with the usage of a web page title.

Interestingly, PWA does force you to enter a "longer name". It actually makes a lot more sense for this one to be inherited from the forum's title than the short name.

Proposing that the extension allows the user to modify the short name and that both the long and short name default to the forum's title if not specified.

@askvortsov1
Copy link
Owner

Thank you very much! Fixed by merging #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants