Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wavesplit) Comments on the implementation #73

Open
lienz opened this issue Apr 10, 2020 · 2 comments
Open

(Wavesplit) Comments on the implementation #73

lienz opened this issue Apr 10, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@lienz
Copy link

lienz commented Apr 10, 2020

https://github.com/mpariente/asteroid/blob/aa3485bc57ef1f21d37cff43fce69cc3c9c94b1c/egs/wham/WaveSplit/wavesplit.py#L143

Wavesplit uses standard convolutions, not separable (separable worked worse).

https://github.com/mpariente/asteroid/blob/aa3485bc57ef1f21d37cff43fce69cc3c9c94b1c/egs/wham/WaveSplit/wavesplit.py#L166

Before the residual stacks there is a single convolution layer with kernel size 4, 512 filters, no dilation, no stride.
@lienz
Copy link
Author

lienz commented Apr 10, 2020

https://github.com/mpariente/asteroid/blob/aa3485bc57ef1f21d37cff43fce69cc3c9c94b1c/egs/wham/WaveSplit/losses.py#L38
Initializing with one-hot works better.

@mpariente
Copy link
Collaborator

Thanks a lot for the comments @lienz ! We're going to work on it
Just linking the PR #70 for visibility.

@mpariente mpariente added the enhancement New feature or request label May 1, 2020
@jonashaag jonashaag changed the title Comments on the implementation (Wavesplit) Comments on the implementation Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpariente @lienz