You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Even if the detection+fix ability is better now that these are implemented in UP006, something needs to be done about the fact that the newly added warnings are all duplicates of warnings and fixes that already exist in UP035.
If this implementation becomes a little more polished, it probably should completely replace the implementation that's currently in UP035, there's really no reason to still keep that inferior implementation other than its battle-tested status. Although maybe for historic consistency, even if the implementation is unified towards UP006, the set of items that it triggers for should remain split between UP006 (covering only builtins such as list) and UP035 (covering others) like it's always been.
The fixer has bugs where it sometimes fails to kick in, and in corner cases kicks in with strange results.
For now I'd like to see this pull request reverted and relanded later after a more detailed discussion, because it has ongoing bugs and possibly introduces undesirable/unexpected changes to what the rules are supposed to cover.
#5454 added all PEP-585 names to UP006 but this caused multiple issues which is why I decided to revert it in #15250
We should revisit if we want this change and how we resolve possible conflicts, as summarized by a contributor:
The text was updated successfully, but these errors were encountered: