Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider how to regression test fee extraction from raw log message #1013

Open
Fraser999 opened this issue Apr 25, 2024 · 0 comments
Open

Consider how to regression test fee extraction from raw log message #1013

Fraser999 opened this issue Apr 25, 2024 · 0 comments
Assignees
@Fraser999
Labels
celestia interacting with celestia ignore-stale Override for issues or PRs which should not be removed if stale. sequencer-relayer pertaining to the astria-sequencer-relayer crate testing

Comments

@Fraser999
Copy link
Contributor

Fraser999 commented Apr 25, 2024 •
edited by sync-by-unito bot
Loading

This comment pretty much sums things up. Oh God, why, indeed?

Failing Celestia updating their response to hold the required fee as a standalone field (the best possible outcome) we should try to find the least hideous way to avoid a regression of the logic extracting the required fee from the raw log of the response.
@Fraser999 Fraser999 added sequencer-relayer pertaining to the astria-sequencer-relayer crate celestia interacting with celestia testing labels Apr 25, 2024
@Fraser999 Fraser999 mentioned this issue Apr 25, 2024
Merged
@Fraser999 Fraser999 self-assigned this Jun 10, 2024
@Fraser999 Fraser999 added ignore-stale Override for issues or PRs which should not be removed if stale. and removed ignore-stale Override for issues or PRs which should not be removed if stale. stale labels Dec 16, 2024
@joroshiba joroshiba added the ignore-stale Override for issues or PRs which should not be removed if stale. label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fraser999 Fraser999

Labels
celestia interacting with celestia ignore-stale Override for issues or PRs which should not be removed if stale. sequencer-relayer pertaining to the astria-sequencer-relayer crate testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Fraser999 @joroshiba