Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full execution tests for ics20 withdrawals #1345

Open
SuperFluffy opened this issue Aug 2, 2024 · 1 comment
Open

Add full execution tests for ics20 withdrawals #1345

SuperFluffy opened this issue Aug 2, 2024 · 1 comment
Labels
ignore-stale Override for issues or PRs which should not be removed if stale. sequencer pertaining to the astria-sequencer crate stale tech-debt testing

Comments

@SuperFluffy
Copy link
Member

SuperFluffy commented Aug 2, 2024 •
edited by sync-by-unito bot
Loading

#1344 checks if the correct account to withdraw funds from has been established. What's missing however is a check for the full Ics20Withdrawal::check_and_execute being correct. This was not included in the PR because setting the necessary IBC channel and ports is not trivial since penumbra-ibc:v0.78.0 is not exporting the needed StateWriteExt traits.

┆Issue Number: ENG-688
@SuperFluffy SuperFluffy added sequencer pertaining to the astria-sequencer crate testing labels Aug 2, 2024
This was referenced Aug 19, 2024
Merged
Closed
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@joroshiba joroshiba added stale ignore-stale Override for issues or PRs which should not be removed if stale. tech-debt labels Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ignore-stale Override for issues or PRs which should not be removed if stale. sequencer pertaining to the astria-sequencer crate stale tech-debt testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joroshiba @SuperFluffy