Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sequencer: implement oracle-related actions #1446

Open
noot opened this issue Sep 4, 2024 · 1 comment
Open

sequencer: implement oracle-related actions #1446

noot opened this issue Sep 4, 2024 · 1 comment
Assignees
Labels
sequencer pertaining to the astria-sequencer crate

Comments

@noot
Copy link
Collaborator

noot commented Sep 4, 2024

follow up to #1236.

slinky contains Msg types which should be implemented as actions within the sequencer:

┆Issue Number: ENG-786

@noot noot added the sequencer pertaining to the astria-sequencer crate label Sep 4, 2024
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@noot noot removed the stale label Dec 13, 2024
@joroshiba joroshiba modified the milestone: Astria-1 Jan 3, 2025
noot added a commit that referenced this issue Jan 8, 2025
## Summary
implement oracle module actions `AddCurrencyPair` and
`RemoveCurrencyPair`

see
https://github.com/skip-mev/connect/blob/main/proto/connect/oracle/v2/tx.proto
and
https://github.com/skip-mev/connect/blob/9ea31680774e2f71e683c0a4989df5bf2d5f2302/x/oracle/keeper/msg_server.go#L28
for relevant connect code

## Background

these are required for the oracle authorities to be able to add/remove
currency pairs from state; these are the pairs whose prices will be
included in VEs.

## Changes
- implement oracle module actions `AddCurrencyPair` and
`RemoveCurrencyPair`
- make `CurrencyPairState.QuotePrice` optional, to reflect that this may
not be set upon currency pair initialization (as no oracle price has
been received for it)
- remove `get/put_num_removed_currency_pairs` from the oracle state_ext
as it's not needed for our logic due to the fact that we execute txs in
the proposal phase, so by the time vote extensions are issued for a
block, the state has already been updated and currency pairs that are
removed in that block have already been removed.

## Testing
unit tests

## Breaking Changelist
- adds new actions to the sequencer
- sequencer genesis is also updated (new fees)

## Related Issues

part of # #1446
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

No branches or pull requests

3 participants