Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused serde traits #1603

Open
Fraser999 opened this issue Sep 30, 2024 · 1 comment
Open

Remove unused serde traits #1603

Fraser999 opened this issue Sep 30, 2024 · 1 comment
Labels
code-quality ignore-stale Override for issues or PRs which should not be removed if stale. stale tech-debt

Comments

@Fraser999
Copy link
Contributor

Fraser999 commented Sep 30, 2024

We should remove the serde traits on the following types as the functionality is no longer required:

  • TransactionId in astria-core
  • Address in astria-core
  • Deposit in astria-core
  • Proof in astria-merkle

This is effectively reverting commit 3c47298.

Note that removing the impl for Deposit requires replacing it with a Display impl, or potentially a Valuable impl.

The Display impl could be implemented as follows:

impl Display for Deposit {
    fn fmt(&self, formatter: &mut Formatter<'_>) -> std::fmt::Result {
        write!(
            formatter,
            "Deposit[bridge address: {}, rollup id: {}, amount: {}, asset: {}, destination chain \
             address: {}]",
            self.bridge_address,
            self.rollup_id,
            self.amount,
            self.asset,
            self.destination_chain_address,
        )
    }
}

┆Issue Number: ENG-893

@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@Fraser999 Fraser999 added the ignore-stale Override for issues or PRs which should not be removed if stale. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality ignore-stale Override for issues or PRs which should not be removed if stale. stale tech-debt
Projects
None yet
Development

No branches or pull requests

2 participants