Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide stream for reading rollup data in sequencer #1606

Open
Fraser999 opened this issue Oct 1, 2024 · 1 comment
Open

Provide stream for reading rollup data in sequencer #1606

Fraser999 opened this issue Oct 1, 2024 · 1 comment
Labels
code-quality performance sequencer pertaining to the astria-sequencer crate

Comments

@Fraser999
Copy link
Contributor

Fraser999 commented Oct 1, 2024 •
edited by sync-by-unito bot
Loading

We currently call state.get_rollup_data(...).await in a loop when fetching a sequencer block. We should change this to use an async stream instead.

See comment here for more context.

┆Issue Number: ENG-896
@Fraser999 Fraser999 mentioned this issue Oct 1, 2024
Merged
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@Fraser999 Fraser999 added ignore-stale Override for issues or PRs which should not be removed if stale. and removed ignore-stale Override for issues or PRs which should not be removed if stale. stale labels Dec 16, 2024
@SuperFluffy SuperFluffy added sequencer pertaining to the astria-sequencer crate performance code-quality labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality performance sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fraser999 @joroshiba @SuperFluffy