sequencer: use address bytes directly in handle_check_tx() logic

[Lilyjjo]

In the handle_check_tx() logic we're using a heavy weight address computation instead of using the address bytes directly. We should change this to just use the bytes. We should also remove the associated metric when making the change.

// TODO: change rest of code to allow just using bytes instead of having to
// generate this function
let address = match state
        .try_base_prefixed(signed_tx.verification_key().address_bytes())
        .await
        .context("failed to generate address for signed transaction")
    {
        Err(err) => {
            return Err(response::CheckTx {
                code: Code::Err(AbciErrorCode::INTERNAL_ERROR.value()),
                info: AbciErrorCode::INTERNAL_ERROR.info(),
                log: format!("failed to generate address because: {err:#}"),
                ..response::CheckTx::default()
            });
        }
        Ok(address) => address,
    };

┆Issue Number: ENG-903

[joroshiba]

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

[joroshiba]

This issue was closed because it was stale

[Fraser999]

Still worthwhile to do this - should be fairly simple to implement I think.