Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve composer test efficiency #1920

Open
ethanoroshiba opened this issue Jan 21, 2025 · 0 comments · May be fixed by #1925
Open

Improve composer test efficiency #1920

ethanoroshiba opened this issue Jan 21, 2025 · 0 comments · May be fixed by #1925
Assignees
Labels
composer pertaining to composer testing

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Jan 21, 2025

@Fraser999 pointed out that this line has the potential to introduce delay even if initialization is already complete, due to sleeping before the if statement:

tokio::time::sleep(Duration::from_secs(1)).await;

The proposed solution is to change to tokio::task::yield_now().await;, which greatly improves the speed of many tests, but causes some others to fail, which will need to be reevaluated.

┆Issue Number: ENG-1074

@ethanoroshiba ethanoroshiba added composer pertaining to composer testing labels Jan 21, 2025
@ethanoroshiba ethanoroshiba self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
composer pertaining to composer testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant