Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow span mixins to define float direction #121

Open
pixelwhip opened this issue Aug 6, 2013 · 4 comments
Open

Allow span mixins to define float direction #121

pixelwhip opened this issue Aug 6, 2013 · 4 comments

Comments

@pixelwhip
Copy link
Contributor

One of the nice features of zen-grids and the isolation method is being able to control the float direction when spanning the grid. This is super helpful when you 3 divs and a two column layout. You may want the 1st to float left; 2nd to float right and clear none; the 3rd to float left and clear left. This allows the 3rd div to sit below the 1st regardless of the length of the 2nd.

I've messed with the $direction variable. It does the trick in terms of the CSS output I'm looking for except it also adds the [dir="rtl"] selector. A nice feature, but in this case I'm not trying to change the language direction, just the float direction for layout purposes.

I noticed the rtl selector used to be configurable and I thought I could set it to ''; but that seems super hacky anyway.

I also tried setting the direction on the span mixin itself but it only affects clearing, not floats and margins.

Is there a way to do this that I'm missing?

@scottkellum
Copy link
Member

@pixelwhip I think we may need to add something for this use case.

@Snugug
Copy link
Member

Snugug commented Jan 5, 2014

With improvements made in #157, we should be able to implement this fairly easily.

@Snugug Snugug closed this as completed in 5fe5a3a Jan 12, 2014
@pixelwhip
Copy link
Contributor Author

Yeeeeeeeeahhhhhhhhh!!!!! Thanks. I'll be trying this out real soon.

@Snugug
Copy link
Member

Snugug commented Jan 21, 2014

I realized my logic for this is probably off, so I should look into this again.

@Snugug Snugug reopened this Jan 21, 2014
@Snugug Snugug removed this from the v1.2.0 milestone Aug 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants