Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning on empty message formatted by glue #35

Closed
daroczig opened this issue Mar 5, 2024 · 1 comment
Closed

warning on empty message formatted by glue #35

daroczig opened this issue Mar 5, 2024 · 1 comment

Comments

@daroczig
Copy link

daroczig commented Mar 5, 2024

Hi,

While preparing a CRAN update and running the reverse dependency checks for logger, I've run into an issue with https://github.com/atalv/azlogr/blob/main/tests/testthat/test-logger_level.R#L161 -- daroczig/logger#147 introduced throwing a warning when formatter_glue return no message to note to the user that something is off.

Your above test line explicitly expects no warnings, so the above PR could not go into main, and we had to revert the PR.

Would you feel comfortable dropping that test line and accepting a warning from formatter_glue when it renders no message? If that's an unwanted behaviour, could you please comment on daroczig/logger#130 so that we can discuss what's a good solution for your use-cases?

Thanks,
Gergely (maintainer of logger)

daroczig added a commit to daroczig/logger that referenced this issue Mar 5, 2024
@atalv atalv closed this as completed in 7891073 Mar 21, 2024
@atalv
Copy link
Owner

atalv commented Mar 21, 2024

Makes sense. I made relevant changes and submitted to CRAN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants