You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your above test line explicitly expects no warnings, so the above PR could not go into main, and we had to revert the PR.
Would you feel comfortable dropping that test line and accepting a warning from formatter_glue when it renders no message? If that's an unwanted behaviour, could you please comment on daroczig/logger#130 so that we can discuss what's a good solution for your use-cases?
Thanks,
Gergely (maintainer of logger)
The text was updated successfully, but these errors were encountered:
daroczig
added a commit
to daroczig/logger
that referenced
this issue
Mar 5, 2024
Hi,
While preparing a CRAN update and running the reverse dependency checks for
logger
, I've run into an issue with https://github.com/atalv/azlogr/blob/main/tests/testthat/test-logger_level.R#L161 -- daroczig/logger#147 introduced throwing a warning whenformatter_glue
return no message to note to the user that something is off.Your above test line explicitly expects no warnings, so the above PR could not go into
main
, and we had to revert the PR.Would you feel comfortable dropping that test line and accepting a warning from
formatter_glue
when it renders no message? If that's an unwanted behaviour, could you please comment on daroczig/logger#130 so that we can discuss what's a good solution for your use-cases?Thanks,
Gergely (maintainer of
logger
)The text was updated successfully, but these errors were encountered: