Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of <!--dark:matter--> #74

Open
einar-hjortdal opened this issue May 28, 2024 · 3 comments
Open

Usage of <!--dark:matter--> #74

einar-hjortdal opened this issue May 28, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@einar-hjortdal
Copy link

einar-hjortdal commented May 28, 2024

I have noticed Dark renders <!--dark:matter--> whenever a component returns null, is this used by anything?
I only see tests that check for the existence of these comments

@atellmer
Copy link
Owner

Sorry, I won't be able to work on the project for a while because I have problems with my eye health. 😢

@einar-hjortdal
Copy link
Author

Sorry, I won't be able to work on the project for a while because I have problems with my eye health. 😢

Take care, I wish you a speedy recovery

@atellmer
Copy link
Owner

atellmer commented Jun 5, 2024

This comment is necessary to ensure that the component always reserves at least 1 real DOM element. This is necessary for conditional rendering to work. However, as far as I found out while designing the architecture, it is possible to get by without actually inserting this comment into the DOM. I'll probably try to do this in the future, but this task is not a priority.

@atellmer atellmer added the enhancement New feature or request label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants