From 61c57af4c7461298fec295db23802452516bca59 Mon Sep 17 00:00:00 2001 From: "Andre A. Gomes" Date: Mon, 13 Nov 2023 23:38:47 +0200 Subject: [PATCH] browser: Simplify external-editor-program API. Handle string values exclusively. --- source/browser.lisp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/source/browser.lisp b/source/browser.lisp index fd203fdca0d..4cc1a0af3c2 100644 --- a/source/browser.lisp +++ b/source/browser.lisp @@ -274,7 +274,7 @@ The handlers take the `prompt-buffer' as argument.") (or (uiop:getenvp "VISUAL") (uiop:getenvp "EDITOR") (when (sera:resolve-executable "gio") "gio open")) - :type (or (cons string *) string null) + :type (or string null) :reader nil :writer t :export t @@ -306,10 +306,9 @@ prevents otherwise.") (defmethod external-editor-program ((browser browser)) "Specialized reader for `external-editor-program' slot." (with-slots ((cmd external-editor-program)) browser - (typecase cmd - (list (unless (sera:blankp (first cmd)) cmd)) - (string (unless (sera:blankp cmd) (str:split " " cmd))) - (t (echo-warning "Invalid value of `external-editor-program' browser slot.") nil)))) + (if (str:blank? cmd) + (progn (echo-warning "Invalid value of `external-editor-program' browser slot.") nil) + (str:split " " cmd)))) (defmethod get-containing-window-for-buffer ((buffer buffer) (browser browser)) "Get the window containing a buffer."