Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] deleteTemporaryTable() triggers text-change as user #66

Open
devinmuzzy opened this issue Jan 29, 2025 · 2 comments
Open

[Bug] deleteTemporaryTable() triggers text-change as user #66

devinmuzzy opened this issue Jan 29, 2025 · 2 comments

Comments

@devinmuzzy
Copy link

Calling deleteTemporaryTable() emits a text-change event with the source Quill.sources.USER. Instead, the source should be Quill.sources.API.

Reproducing

Using the demo linked below, insert a table, click the deleteTemporaryTable button, then look at the logs.

https://codepen.io/devinmuzzy/pen/dPbaNNp

@attoae
Copy link
Owner

attoae commented Feb 9, 2025

this.emitter.emit(Emitter.events.SCROLL_UPDATE, source, mutations);

quill.scroll.update default Emitter.sources.USER.
Quill.sources.API or Quill.sources.USER, this does not affect functionality.

@devinmuzzy
Copy link
Author

I'm not sure I understand what you mean. When using this as part of a bigger project it is important that actions not triggered by the user like calling deleteTemporaryTable() do not emit any 'user' source events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants