Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cppcheck: report and fix false negative in mem-overlap/strcpy-0006 #17

Open
lzaoral opened this issue Oct 4, 2021 · 2 comments
Open

cppcheck: report and fix false negative in mem-overlap/strcpy-0006 #17

lzaoral opened this issue Oct 4, 2021 · 2 comments
Assignees
@psimovec
Labels
bug Something isn't working

Comments

@lzaoral
Copy link
Member

lzaoral commented Oct 4, 2021

Cppcheck 2.6 added support for memory overlap checking. However, this error in strcpy is undetected. This should be fixed in upstream and then updated in this benchmark.
@lzaoral lzaoral changed the title cppcheck: report anf fix false negative in mem-overlap/strcpy-0006 cppcheck: report and fix false negative in mem-overlap/strcpy-0006 Oct 4, 2021
@psimovec
Copy link
Contributor

psimovec commented Oct 6, 2021

relevant comment at commit where check for strncpy was added:
danmar/cppcheck@6234b54#commitcomment-53225278
Here it seems like that strcpy is just not implemented yet

@psimovec
Copy link
Contributor

psimovec commented Oct 7, 2021 •
edited
Loading

I will create PR in cppcheck adding the failing test case here + include additional info

@lzaoral lzaoral added the bug Something isn't working label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@psimovec psimovec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lzaoral @psimovec