Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up public api for merkle mod #362

Closed
richardpringle opened this issue Nov 20, 2023 · 1 comment
Closed

Clean up public api for merkle mod #362

richardpringle opened this issue Nov 20, 2023 · 1 comment

Comments

@richardpringle
Copy link
Contributor

richardpringle commented Nov 20, 2023 •
edited
Loading 

          pub(crate) or pub(super). We don't want these as part of the public API.

Originally posted by @rkuris in #360 (comment)

          nit: LeafNode shouldn't escape the crate, so the inner ones can just be pub, but this one should be `pub(crate)`.

Originally posted by @rkuris in #360 (comment)
This was referenced Nov 20, 2023
Merged
Closed
@rkuris
Copy link
Collaborator

rkuris commented Oct 11, 2024

Fixed with new design

@rkuris rkuris closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rkuris @richardpringle