Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move encode_regression_test from leaf.rs to partial_path.rs with necessary changes #365

Closed
richardpringle opened this issue Nov 21, 2023 · 1 comment
Closed

Move encode_regression_test from leaf.rs to partial_path.rs with necessary changes #365

richardpringle opened this issue Nov 21, 2023 · 1 comment

Comments

@richardpringle
Copy link
Contributor 

          Is this just testing `partial_path`? If you're checking to see if the node is storing it correctly, rather than hardcoding this here (which can change if partial_path changes), perhaps use partial_path and compare that encoding?

Originally posted by @rkuris in #360 (comment)
@richardpringle richardpringle mentioned this issue Nov 21, 2023
Merged
@richardpringle richardpringle removed their assignment Feb 12, 2024
@rkuris
Copy link
Collaborator

rkuris commented Jun 10, 2024

No longer a factor with new design

@rkuris rkuris closed this as completed Jun 10, 2024
@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to Done ✅ in Platform Engineering Group Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rkuris @richardpringle