Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove From<Vec<u8>> implementation from PartialPath #366

Closed
1 of 4 tasks
richardpringle opened this issue Nov 21, 2023 · 1 comment
Closed
1 of 4 tasks

Remove From<Vec<u8>> implementation from PartialPath #366

richardpringle opened this issue Nov 21, 2023 · 1 comment

Comments

@richardpringle
Copy link
Contributor

richardpringle commented Nov 21, 2023 •
edited by rkuris
Loading

It's now too easy for someone to put non-nibbles into a PartialPath.

This also ties PartialPath more strongly to a Vec, which is something I'd like to change.

Originally posted by @rkuris in #360 (comment)

  • Remove From<Vec<u8>> implementation
  • Make it easier to extend a PartialPath
  • Make it easier to shorten a PartialPath
  • Consider using smallvec or tinyvec to reduce allocations
@richardpringle richardpringle mentioned this issue Nov 21, 2023
Merged
@richardpringle richardpringle removed their assignment Feb 12, 2024
@rkuris
Copy link
Collaborator

rkuris commented Jun 10, 2024

PartialPath has been completely revamped with new design

@rkuris rkuris closed this as completed Jun 10, 2024
@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to Done ✅ in Platform Engineering Group Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rkuris @richardpringle