Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code tidy and improvement #26

Open
1 of 6 tasks
avastmick opened this issue Feb 9, 2024 · 0 comments · Fixed by #38
Open
1 of 6 tasks

Code tidy and improvement #26

avastmick opened this issue Feb 9, 2024 · 0 comments · Fixed by #38
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@avastmick
Copy link
Owner

avastmick commented Feb 9, 2024

The original code was written quickly straight after the Gemini API was released. There are poor parts of the code:

  • readability in places is poor.
  • repeated code segments.
  • Shift impl logic into sensible module to split up the Client
  • little to no test coverage.
  • no CI testing.
  • poor structuring.
@avastmick avastmick added enhancement New feature or request help wanted Extra attention is needed labels Feb 9, 2024
@avastmick avastmick added this to the v1.0.0 milestone Feb 9, 2024
@avastmick avastmick pinned this issue Feb 9, 2024
@avastmick avastmick linked a pull request May 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant