Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper formatting of some files #56

Open
suufi opened this issue Oct 6, 2018 · 6 comments
Open

Improper formatting of some files #56

suufi opened this issue Oct 6, 2018 · 6 comments
Labels
enhancement New feature or request Hacktoberfest Label for hacktoberfest 2018 help wanted Extra attention is needed

Comments

@suufi
Copy link
Contributor

suufi commented Oct 6, 2018

Some of these files seem really rushed and aren't formatted properly (either not proper Markdown or not a Markdown file at all) making it hard for some users to read.

Examples:
https://github.com/avsingh999/Ruby-for-Beginner/blob/master/Functions-in-Ruby
https://github.com/avsingh999/Ruby-for-Beginner/blob/master/Array_in_Ruby.md
https://github.com/avsingh999/Ruby-for-Beginner/blob/master/Block_in_Ruby.md
https://github.com/avsingh999/Ruby-for-Beginner/blob/master/How%20to%20find%20index%20of%20element%20in%20array%20ruby.md

@avsingh999 avsingh999 added enhancement New feature or request help wanted Extra attention is needed Hacktoberfest Label for hacktoberfest 2018 labels Oct 7, 2018
@avsingh999
Copy link
Owner

@suufi would you like to solve it

@avsingh999
Copy link
Owner

@suufi go ahead
thank you :)

@suufi
Copy link
Contributor Author

suufi commented Oct 16, 2018 via email

@luhova
Copy link
Contributor

luhova commented Oct 16, 2018

Hello, I would like to work on this issue. A PR will be pushed shortly.

@C-Lion
Copy link
Contributor

C-Lion commented Oct 17, 2018

@luhova Sorry, oddly, I only see your comment from 5 hrs ago now, after my PR. But luckily it looks like I fixed a different file from what you did.

@suufi
Copy link
Contributor Author

suufi commented Oct 18, 2018

@avsingh999 I think it would be easier to not accept merge PRs that aren't formatted a certain way.
Example guidelines:

  • Proper use of section headings
  • Proper file type
  • Proper encapsulation of code (including code type) with three backticks like this and this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest Label for hacktoberfest 2018 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants