Issue/248 - CPT/Taxos: unwind deep integration. #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only partially working, and after further review was a bit too aggressive with everything that it attempted to rearrange. This commit introduces sugar_calendar_admin_is_assets_page() and sugar_calendar_is_supported_type() helper functions, and uses them where helpful. This change removes the way that supported post types (other than "sc_events") would be redirected to the main admin area calendar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only partially working, and after further review was a bit too aggressive with everything that it attempted to rearrange.
This commit introduces sugar_calendar_admin_is_assets_page() and sugar_calendar_is_supported_type() helper functions, and uses them where helpful.
This PR removes the way that supported post types (other than "sc_events") would be redirected to the main admin area calendar. It will soon explore a better way.
See #248