Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(amplify-cli-core): use build script for overrides (#13858)" #14092

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Jan 31, 2025

This reverts commit 30c9f0c.

Description of changes

@brianlenz I'm sorry but I have to revert #13858 .

Upon further verification it turned out that it doesn't work with npm. I haven't checked pnpm but this is enough signal to revert.

Repro steps:

  1. Create amplify project
  2. Add auth and data
  3. Override auth and data.
  4. cd amplify/backend/ && rm yarn.lock && rm -rf node_modules && npm install && cd .. && cd ..
  5. amplify build

image

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner January 31, 2025 21:20
rtpascual
rtpascual previously approved these changes Jan 31, 2025
@sobolk sobolk dismissed rtpascual’s stale review January 31, 2025 21:28

re-do for admin

@sobolk sobolk merged commit 4d368b3 into aws-amplify:dev Jan 31, 2025
5 checks passed
@brianlenz
Copy link
Contributor

@sobolk what do you think about adding the alternative from my PR as a fallback? E.g. if tsc isn't found in node_modules, then try to run the build script? I think there has to be a solution that works for both worlds (so that simple npm cases like this work, but hoisting cases can work, too).

@brianlenz
Copy link
Contributor

@sobolk nevermind; I spent some time on it today and came up with a more holistic solution. We just needed a small tweak to my previous PR to get it working with npm. Sorry about the bug in the original PR! This one is good now (tested yarn and npm): #14093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants