Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reserved named shadows #206

Open
1 of 2 tasks
tamarindsoup opened this issue Jun 22, 2024 · 3 comments
Open
1 of 2 tasks

Add support for reserved named shadows #206

tamarindsoup opened this issue Jun 22, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@tamarindsoup
Copy link

Feature Description
Add support for reserved named shadows, namely, shadows that start with a $.

Use Case
I'm thinking of creating a custom Greengrass component that reports the version of a natively installed software to the Software Package Catalog. I'd like the component to access the $package shadow through Shadow manager.

Proposed Solution
Change SHADOW_PATTERN to allow shadow names prefixed with a $. (e.g. \\$?[a-zA-Z0-9:_-]+)

public static final String SHADOW_PATTERN = "[a-zA-Z0-9:_-]+";

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@saranyailla
Copy link
Member

Hi, thank you for bringing this to our attention.

Currently, Greengrass shadow manager component lets you manage AWS IoT Device shadows that are either named or classic only. For these configured shadows, shadow manager subscribes to their reserved MQTT topics to perform shadow operations.

To support reserved named shadows such as $package, we'll have to investigate all that it entails and evaluate the usecases. Adding it to our backlog for further evaluation.

@saranyailla saranyailla added the enhancement New feature or request label Jun 25, 2024
@tamarindsoup
Copy link
Author

Hi @saranyailla, thank you for your response.

I only changed the regex and it seemed to work fine, so I'd hoped it'd be a quick and easy fix, but I understand your need for a more thorough evaluation. I guess I'll keep using my fork for the time being. 😄

Do you have a rough estimate of when this issue would be resolved?

@saranyailla
Copy link
Member

We don't have an estimated timeline for this one yet. We'll use this thread to post any updates if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants