Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GreengrassCliSteps): Check "the local Greengrass deployment is SUCCEEDED" always true #212

Open
bgklika opened this issue Jul 4, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@bgklika
Copy link
Contributor

bgklika commented Jul 4, 2023

Describe the bug
Check "the local Greengrass deployment is SUCCEEDED" always true

Priority
High due to affect all clients of OTF

To Reproduce

  1. Make local deployment which will fail: for example component do just 'exit 1'

  2. Disable MQTT and HTTPS connections from device to backend.

  3. Run scenario with steps like:

I install the component <NAME> from local store with configuration
the local Greengrass deployment is SUCCEEDED on the device after 120 seconds
  1. And the first and second steps will passed

Expected behavior
When local deployment is failed step to check is deployment SUCCEEDED should fail.

Actual behavior
Step is passed. In greengrass.log we observe deployment failure.

Environment

  • Ubuntu 20.04, Windows 11
  • JDK version: JDK11
  • Nucleus version: 2.11.0

Additional context
Add any other context about the problem here.

E.g. what is the impact of the bug?

@bgklika bgklika added the bug Something isn't working label Jul 4, 2023
@bgklika
Copy link
Contributor Author

bgklika commented Jul 14, 2023

Try do local deployment of failed component manually by running greengrass cli.
After that found deployment status is FAILED.

There are two reasons of the issue

  1. OTF do not correctly handle FAILED status of deployment
  2. Local deployment marked as SUCCEEDED by Nucleus buy actually component is not running.

@bgklika
Copy link
Contributor Author

bgklika commented Aug 28, 2023

Another related problem. When I write "And the local Greengrass deployment is SUCCEEDED on the device after 120 seconds" whole 120 seconds are spend in the step. Not good for performance of scenarios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant