Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving docker buildx -> ko #2258

Closed
jayanthvn opened this issue Feb 8, 2023 · 8 comments
Closed

Consider moving docker buildx -> ko #2258

jayanthvn opened this issue Feb 8, 2023 · 8 comments

Comments

@jayanthvn
Copy link
Contributor

What would you like to be added:
Multi-arch image build uses docker buildx and that takes a lot of time. One example - https://github.com/aws/amazon-vpc-cni-k8s/actions/runs/4119775035/jobs/7113817570 , it took 40+ mins and some times more than an hour or so.

AWS LB cntrl moved away from buildx to ko and saw improvements from 2 hrs to 15 mins, we need to evaluate if that would benefit with faster builds for multi-arch images - kubernetes-sigs/aws-load-balancer-controller#2955

Why is this needed:
Faster builds during PR merges. Maybe not urgent but something to POC.

@jdn5126
Copy link
Contributor

jdn5126 commented Feb 8, 2023

I can try this out. I think we should also remove the go mod download calls as they do not help much with layer caching and add a significant amount of time pulling unnecessary modules and their dependencies.

@jdn5126 jdn5126 self-assigned this Feb 8, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Apr 10, 2023
@jdn5126 jdn5126 removed their assignment Apr 10, 2023
@jdn5126 jdn5126 removed the stale Issue or PR is stale label Apr 10, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Jun 10, 2023
@jayanthvn
Copy link
Contributor Author

/not stale

@github-actions github-actions bot removed the stale Issue or PR is stale label Jun 12, 2023
@jaydeokar jaydeokar self-assigned this Jun 26, 2023
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Issue or PR is stale label Aug 26, 2023
@jdn5126 jdn5126 removed the stale Issue or PR is stale label Aug 28, 2023
@jchen6585
Copy link
Contributor

jchen6585 commented Sep 5, 2023

This seems unviable based on what I have seen today. Today we build multiple binaries into a single image as seen in our Dockerfile.release file. This contradicts this statement right here. This github issue in the Ko repo also hints that this is unviable as of now. I took a look at the repo tagged in this issue and also the VPC-RC repo, and see that they are using Ko to build an image with a single binary which is based off of the main.go file in the root directory. Please correct me if I am wrong. Thanks!

@jdn5126 jdn5126 removed the testing label Sep 6, 2023
@jdn5126
Copy link
Contributor

jdn5126 commented Sep 6, 2023

Thanks for digging into this @jchen6585! From the ko documentation and that issue, I agree with your conclusion. I think we can close this issue as one that we explored, but concluded as not currently feasible.

@jdn5126 jdn5126 closed this as completed Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants