s3: set EventBridgeEnabled using CloudFormation not CustomResource

[zaccharles]

Describe the feature

The eventBridgeEnabled property on the S3 Bucket construct results in provisioning a custom resource to enable or disable EventBridge notifications.

I'm guessing this was added before CloudFormation supported this, but it does now.

Use Case

This is especially bothersome when creating templates for Service Catalog products, as they can't easily use CustomResources like regular stacks.

In general, it just seems unnecessary to create everything around this CustomResource for something we could do natively.

Proposed Solution

Set NotificationConfiguration.EventBridgeConfiguration.EventBridgeEnabled to true|false based on the eventBridgeEnabled prop and don't use the CustomResource.

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.64.0

Environment details (OS name and version, etc.)

Mac OS 13.1

[pahud]

I'm not sure when cloudformation has added this support but yeah we probably should opt in the native support instead.

[wolfadr]

Using an escape hatch works until it is "fixed" in the L2 construct:

(bucket.node.defaultChild as CfnBucket).notificationConfiguration = {
  eventBridgeConfiguration: {
    eventBridgeEnabled: true,
  },
};

[yerzhan7]

This is duplicate of #26772