Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolkit should support disabling color and emojis in messages #33237

Closed
mrgrain opened this issue Jan 30, 2025 · 1 comment · Fixed by #33244
Closed

Toolkit should support disabling color and emojis in messages #33237

mrgrain opened this issue Jan 30, 2025 · 1 comment · Fixed by #33244

Comments

@mrgrain
Copy link
Contributor

mrgrain commented Jan 30, 2025

Add a new color?: boolean option to the toolkit. Defaults to detect color from TTY status. Setting it to false, should disable all chalk colors globally.

Add a new emojis?: boolean option to the toolkit. Defaults to true. When set to false, all messages need to be stripped of emojis.

@kaizencc kaizencc self-assigned this Jan 30, 2025
mergify bot pushed a commit that referenced this issue Jan 31, 2025
Implements half of [#33237](#33237)

```ts
new Toolkit({ ioHost, emojis: false });
```

Can strip emojis by specifying the property when creating the `Toolkit`.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this issue Jan 31, 2025
Closes [#33237](#33237) along with #33243.

```ts
new Toolkit({ ioHost, color: false });
```

Can strip color and style by specifying the property when creating the `Toolkit`.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mergify mergify bot closed this as completed in #33244 Jan 31, 2025
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants