Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Monitoring: errors calling asset-library don't show as lambda errors #105

Open
1 of 2 tasks
aaronatbissell opened this issue Feb 21, 2023 · 2 comments
Open
1 of 2 tasks
Labels
bug Something isn't working

Comments

@aaronatbissell
Copy link
Contributor

Aws Connected Device Framework Affected Module(s):

device-monitoring

I'm submitting a ...

  • bug report
  • feature request

Description:

When there is an error calling into asset library (specifically an Internal Server Error, but i'm sure other errors), that does not translate into a lambda error.

Current behavior:

When an error happens, the lambda still returns a successful return code

Expected behavior:

When an error happens, the lambda should return an unsuccessful return code

Steps to reproduce:

Additional Information:

Screen Shot 2023-02-21 at 11 00 58 AM
Screen Shot 2023-02-21 at 11 00 01 AM

@anish-kunduru anish-kunduru added the bug Something isn't working label Apr 26, 2023
@anish-kunduru
Copy link
Contributor

@aaronatbissell Do you happen to know the block of code that causes the error or the steps to replicate?

This seems like a fairly simple thing to fix, unless it is an issue caused by incorrect data in the asset library.

@aaronatbissell
Copy link
Contributor Author

If I had to guess, it would be here. Looks like we just catch any errors, print a log message and move on. We should probably just throw there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants