Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[keyrings] Update example descriptions to reference "AWS KMS keyring" #176

Closed
mattsb42-aws opened this issue Apr 16, 2020 · 1 comment · Fixed by #177
Closed

[keyrings] Update example descriptions to reference "AWS KMS keyring" #176

mattsb42-aws opened this issue Apr 16, 2020 · 1 comment · Fixed by #177
Assignees
@WesleyRosenblum

Comments

@mattsb42-aws
Copy link
Member

Per awslabs/aws-encryption-sdk-specification#67, we are going to rename the KMS keyring to the AWS KMS keyring to be explicitly clear that this keyring interacts with the AWS Key Management Service, rather than some other KMS.

This does not impact the Java code, but does impact the descriptions in the examples.
@WesleyRosenblum WesleyRosenblum mentioned this issue Apr 16, 2020
Merged
1 task
@WesleyRosenblum WesleyRosenblum self-assigned this Apr 16, 2020
@WesleyRosenblum WesleyRosenblum linked a pull request Apr 16, 2020 that will close this issue
Replace KMS with AWS KMS #177
Merged
1 task
@acioc acioc mentioned this issue Jun 3, 2020
Open
@acioc
Copy link
Contributor

acioc commented Jun 3, 2020

Spec issue merged. Spec issue tracking the completion of this implementation in awslabs/aws-encryption-sdk-specification#127 (adding link here so it properly links and shows up as closed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WesleyRosenblum WesleyRosenblum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace KMS with AWS KMS aws/aws-encryption-sdk-java
3 participants
@acioc @mattsb42-aws @WesleyRosenblum