Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KeyID naming, pass key names as-is to AWS KMS #196

Closed
acioc opened this issue Jun 4, 2020 · 2 comments
Closed

Update KeyID naming, pass key names as-is to AWS KMS #196

acioc opened this issue Jun 4, 2020 · 2 comments
Assignees
@acioc
Labels
spec deviation

Comments

@acioc
Copy link
Contributor

acioc commented Jun 4, 2020

Per awslabs/aws-encryption-sdk-specification#123 , we are renaming "Key IDs" to "Key Names" for the AWS KMS keyring. We are additionally ensuring we support all AWSK KMS key identifiers that AWS KMS supports by passing key names as-is to AWS KMS without additional limitations. The spec did not originally allow unqualified key ids, so key ids will work after this change is implemented. Please refer to the new spec change linked for more information.
@acioc
Copy link
Contributor Author

acioc commented Jun 4, 2020

Tracking via awslabs/aws-encryption-sdk-specification#129

@acioc acioc self-assigned this Aug 7, 2020
@acioc acioc mentioned this issue Aug 17, 2020
Merged
1 task
@lavaleri
Copy link
Contributor

lavaleri commented Dec 9, 2021

We are pursuing another mechanism to ensure that the implementation meets the specification.

@lavaleri lavaleri closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acioc acioc

Labels
spec deviation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@acioc @robin-aws @lavaleri