You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our team wants to subclass MetricsLogger to track which metrics properties are being set. However, we are facing two issues that are preventing us from doing so:
The context property is private. This requires us to manually track the properties that have been set through setProperty.
MetricsLogger's constructor requires parameters whose types are defined in internal modules, which makes it difficult to define a constructor of our own in the subclass.
Ask
Our request is to make MetricsLogger more amenable to subclassing. Specifically, we would like to
Make MetricsLogger.context a protected property
Export resolveEnvironment and MetricsContext in the index.js as part of aws-embedded-metrics-node's public API.
I am happy to submit a PR if our request is approved.
The text was updated successfully, but these errors were encountered:
Context
Our team wants to subclass
MetricsLogger
to track which metrics properties are being set. However, we are facing two issues that are preventing us from doing so:context
property is private. This requires us to manually track the properties that have been set throughsetProperty
.MetricsLogger
's constructor requires parameters whose types are defined in internal modules, which makes it difficult to define a constructor of our own in the subclass.Ask
Our request is to make
MetricsLogger
more amenable to subclassing. Specifically, we would like toMetricsLogger.context
a protected propertyresolveEnvironment
andMetricsContext
in theindex.js
as part ofaws-embedded-metrics-node
's public API.I am happy to submit a PR if our request is approved.
The text was updated successfully, but these errors were encountered: