Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services names swapped #474

Open
goodbyedavid opened this issue Feb 3, 2023 · 2 comments
Open

services names swapped #474

goodbyedavid opened this issue Feb 3, 2023 · 2 comments
Labels
admin-ui Admin web application needs-reproduction Can't reproduce issue

Comments

@goodbyedavid
Copy link
Contributor

goodbyedavid commented Feb 3, 2023 •
edited
Loading

After creating two services, I defined two tiers for each service.
Once the tiers were created, it is noticed service names were swapped.

Environment

  • **AWS Region : cn-northeast-1
  • **AWS SaaS Boost Version : v2-latest
  • **Workload OS (Linux or Windows) : Linux

Other

截屏2023-02-03 09 45 47

截屏2023-02-03 09 46 16

This is 🐛 Bug Report
@goodbyedavid goodbyedavid added bug Something isn't working triage Needs categorization and prioritization labels Feb 3, 2023
@PoeppingT
Copy link
Contributor

Hi @goodbyedavid , thanks for the bug report! To address this issue we'll need a little more information:

  1. In your picture you show that main has the Service Name field as feature1. Does that main service have the configurations of main or feature1?
  2. What is the exact order of operations you took on your SaaS Boost environment? How much of the application config did you create before creating tiers? How did the application config change once you created the tiers?
  3. Behind the hood, this application configuration is stored as a JSON blob in AWS SSM Parameter Store. Go to your AWS Console, navigate to Systems Manager, click on Parameter Store on the left, and find the parameters named /saas-boost/${environment}/app/${main/feature1}/SERVICE_JSON. Do those JSON parameters match what you expect?

I suspect that this is simply a UI bug, and that the application configuration under the hood is still as you expect: but answers to these questions will help us get to the bottom of the issue.

@brtrvn brtrvn added needs-reproduction Can't reproduce issue admin-ui Admin web application and removed triage Needs categorization and prioritization labels Feb 7, 2023
PoeppingT pushed a commit to PoeppingT/aws-saas-boost that referenced this issue Feb 8, 2023
Improve Application Configuration UX
f052660 
This commit improves on multiple issues with the existing application
configuration page in the admin UI:
1. deleting a service now actually deletes the errors for that service
   from the top banner
2. creating a new service automatically opens the accordion banner for
   that new service
3. the validation error banner won't be shown for new services until any
   error is made (assuming there are not existing errors in other
   services)
4. the accordion name is now controlled directly by the form, rather
   than an alternate state

4/ in the above list should also address awslabs#474, but until we have
reproduction we cannot know for sure.
@PoeppingT PoeppingT mentioned this issue Feb 8, 2023
Merged
@PoeppingT
Copy link
Contributor

#477 may fix this issue, but until we have reproduction we cannot know for sure. @goodbyedavid have you been able to reproduce this issue?

brtrvn pushed a commit that referenced this issue Feb 10, 2023
@PoeppingT
Improve Application Config UX (#477)
f843997 
* Improve Application Configuration UX

This commit improves on multiple issues with the existing application
configuration page in the admin UI:
1. deleting a service now actually deletes the errors for that service
   from the top banner
2. creating a new service automatically opens the accordion banner for
   that new service
3. the validation error banner won't be shown for new services until any
   error is made (assuming there are not existing errors in other
   services)
4. the accordion name is now controlled directly by the form, rather
   than an alternate state

4/ in the above list should also address #474, but until we have
reproduction we cannot know for sure.

* small pre-PR cleanup

* Selected tier should be default tier on appconfig page

---------

Co-authored-by: PoeppingT <[email protected]>
@brtrvn brtrvn removed the bug Something isn't working label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin-ui Admin web application needs-reproduction Can't reproduce issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@goodbyedavid @PoeppingT @brtrvn