Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description of Portfolio doesn't change on update #163

Open
AndyEfaa opened this issue Nov 26, 2020 · 4 comments
Open

Description of Portfolio doesn't change on update #163

AndyEfaa opened this issue Nov 26, 2020 · 4 comments

Comments

@AndyEfaa
Copy link

AndyEfaa commented Nov 26, 2020

We run aws-service-catalog-factory in version 0.48.
During a recent update, we did change the following:

  • Description of a Portfolio
  • Tags of a Portfolio
  • Description of a Product
  • Tags of a Product

After successfully pushing the code and running the pipeline "servicecatalog-factory-pipeline", only the "Description of a Product" got updated. The other values were left unchanged.

@ilgiznurgaliev
Copy link

Hi,

Any updates on this? I have the same issue.

@robbrad
Copy link
Contributor

robbrad commented May 16, 2022

This is because when the tasks are generated for Luigi it only puts a task in for "ensuring" the product details

See:

https://github.com/awslabs/aws-service-catalog-factory/blob/master/servicecatalog_factory/commands/portfolios.py#L291

Portfolio tasks are Create only currently

See:

https://github.com/awslabs/aws-service-catalog-factory/blob/master/servicecatalog_factory/commands/portfolios.py#L320

A new class would need to be created to ensure portfolio or have some logic in the create to do an update if portfolio found

@eamonnfaherty
Copy link
Contributor

Description of a Product updates when you change it but tags are not currently.

@eamonnfaherty
Copy link
Contributor

Description and tags of a Portfolio do not update currently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants