You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please ensure you are using the latest version and have tried to run a validate command on your source files
As in #335, unfortunately unable to use the latest version - this issue is hopefully the last blocker.
I'm not sure if this is just because it's not recommended configuration, however we are still defining our service catalog configuration via a list of products underneath a portfolio.yaml file
We have a couple of products that are shared between two portfolios - this configuration works up to version 0.88.0, however from 0.89.0 we are seeing
Exception: Product productname defined within portfolioname ./portfolios/portfolioname.yaml has already been declared
I am aware that there's a bunch of duplication here and could have unexpected side effects, however in this case the rest of product config is identical between the two portfolios, so the product would be identical
Also, apologies for being 'that guy', but it did work fine before in 0.88.0, could we just add a warning message to say it's a risk if the component info is different, only one will be picked?
Steps to reproduce
Use portfolio configuration mentioned above
run factory build
Expected results
pipelines created with only pipeline called products--productname-v1-pipeline etc.
Actual results
servicecatalog-factory throws the above error when pipeline is started
Worth noting: for the initial runs as I'm trying to upgrade from a very old version, validation is disabled - I'm unsure whether this would have been picked up by validation in the first place though - probably not.
The text was updated successfully, but these errors were encountered:
Please ensure you are using the latest version and have tried to run a validate command on your source files
As in #335, unfortunately unable to use the latest version - this issue is hopefully the last blocker.
I'm not sure if this is just because it's not recommended configuration, however we are still defining our service catalog configuration via a list of products underneath a portfolio.yaml file
We have a couple of products that are shared between two portfolios - this configuration works up to version 0.88.0, however from 0.89.0 we are seeing
Exception: Product productname defined within portfolioname ./portfolios/portfolioname.yaml has already been declared
Looking at the code, this block is responsible for defining the tasks to create a product - could this be skipped instead of an error being raised if the product is already in that dictionary?
https://github.com/awslabs/aws-service-catalog-factory/blob/master/servicecatalog_factory/commands/task_reference.py#L311-L313
example config:
I am aware that there's a bunch of duplication here and could have unexpected side effects, however in this case the
rest of product config
is identical between the two portfolios, so the product would be identicalAlso, apologies for being 'that guy', but it did work fine before in 0.88.0, could we just add a warning message to say it's a risk if the component info is different, only one will be picked?
Steps to reproduce
Expected results
pipelines created with only pipeline called
products--productname-v1-pipeline
etc.Actual results
servicecatalog-factory throws the above error when pipeline is started
Worth noting: for the initial runs as I'm trying to upgrade from a very old version, validation is disabled - I'm unsure whether this would have been picked up by validation in the first place though - probably not.
The text was updated successfully, but these errors were encountered: