Skip creation of product if already present within another portfolio #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #337
Description of changes:
Change from throwing an exception when the task reference / product is already staged to be created, to logging a message and skipping.
This is an attempt to replicate the previous functionality that is present < 0.88.0 - details on the configuration to hit this is in the issue #337
I'm struggling to test this for real - getting
ImportError: cannot import name 'soft_unicode' from 'markupsafe'(using the latest initialiser template) - weirdly 0.100.0 works fine, so am wondering if there's some weirdness / different dependency versions being pulled when installed via git vs from pypi 🤷By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.