Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out if layer filtering can be improved in general #119

Open
mattdelsordo opened this issue Aug 24, 2018 · 0 comments
Open

Figure out if layer filtering can be improved in general #119

mattdelsordo opened this issue Aug 24, 2018 · 0 comments
Labels
performance Something could be optimized

Comments

@mattdelsordo
Copy link
Contributor

At the time of writing, layers are filtered by loading in Mapnik XML as a string, compiling it to JSON, modifying the JSON, and then compiling it back to XML. This was done because Mapnik's layers aren't editable once added to a map object, and layers are only added when maps are generated from XML, so the layers need to change before the map is created (e.g. before there's even an actual JS data structure representing the map). There seems like there should be a more efficient way to do this.

@mattdelsordo mattdelsordo added the performance Something could be optimized label Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Something could be optimized
Projects
None yet
Development

No branches or pull requests

1 participant