-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utilize weakdeps #154
utilize weakdeps #154
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 90.05% 89.59% -0.46%
==========================================
Files 20 20
Lines 1156 1153 -3
==========================================
- Hits 1041 1033 -8
- Misses 115 120 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the PR and sorry for taking a while to get to it. This should have been a breaking change, since |
Hah, interesting :) I didn't even question myself whether something was supposed to use pmap – just removed Distributed and saw that all tests pass. |
It is in the documentation, so it's not unreasonable that people would try to use it. |
wherever possible.
No breaking changes.
And the code itself didn't change at all, it's just github diff isn't the best with file renaming + code moving.