From 2d270f3f3f42d679edfd3d120181e1d164514bd4 Mon Sep 17 00:00:00 2001 From: Alberto Gualis Date: Thu, 9 Feb 2023 15:51:39 +0100 Subject: [PATCH] Avoid wrong token address in tests mocks (#2775) * Avoid wrong token address in tests mocks * Add address to mocked pool --- .eslintrc-auto-import.json | 2 +- .prettierignore | 1 + src/__mocks__/weighted-pool.ts | 1 + .../components/composables/useTokenBreakdown.spec.ts | 6 ------ src/providers/tokens.provider.spec.ts | 12 ++++-------- 5 files changed, 7 insertions(+), 15 deletions(-) diff --git a/.eslintrc-auto-import.json b/.eslintrc-auto-import.json index 42fca42270..bdc45dd2ca 100644 --- a/.eslintrc-auto-import.json +++ b/.eslintrc-auto-import.json @@ -58,4 +58,4 @@ "watchPostEffect": true, "watchSyncEffect": true } -} +} \ No newline at end of file diff --git a/.prettierignore b/.prettierignore index 7a40f01f54..9c4e71414c 100644 --- a/.prettierignore +++ b/.prettierignore @@ -2,3 +2,4 @@ dist/ build/ public/data/tokenlists.json public/data/tokenlists/*.json +.eslintrc-auto-import.json diff --git a/src/__mocks__/weighted-pool.ts b/src/__mocks__/weighted-pool.ts index af2dbbaf8c..cc9d67b7cc 100644 --- a/src/__mocks__/weighted-pool.ts +++ b/src/__mocks__/weighted-pool.ts @@ -9,6 +9,7 @@ type DeepPartial = { const defaults: DeepPartial = { totalLiquidity: '100000000', + address: '0x702605F43471183158938C1a3e5f5A359d7b31ba', tokens: [ aPoolToken({ address: '0x3Ec8798B81485A254928B70CDA1cf0A2BB0B74D7', diff --git a/src/components/contextual/pages/pool/PoolCompositionCard/components/composables/useTokenBreakdown.spec.ts b/src/components/contextual/pages/pool/PoolCompositionCard/components/composables/useTokenBreakdown.spec.ts index a256352abe..e3fbdd240a 100644 --- a/src/components/contextual/pages/pool/PoolCompositionCard/components/composables/useTokenBreakdown.spec.ts +++ b/src/components/contextual/pages/pool/PoolCompositionCard/components/composables/useTokenBreakdown.spec.ts @@ -20,12 +20,6 @@ vi.mock('@/providers/tokens.provider', () => { }; }); -vi.mock('@ethersproject/address', () => { - return { - getAddress: address => address, - }; -}); - const rootPool = BoostedPoolMock; // Values used to calculate userPoolPercentage (15) rootPool.totalLiquidity = '100'; diff --git a/src/providers/tokens.provider.spec.ts b/src/providers/tokens.provider.spec.ts index 2077574f20..d64ff6e7e4 100644 --- a/src/providers/tokens.provider.spec.ts +++ b/src/providers/tokens.provider.spec.ts @@ -14,11 +14,6 @@ import { tokensProvider } from './tokens.provider'; vi.spyOn(console, 'log').mockImplementation(noop); -vi.mock('@ethersproject/address', () => ({ - getAddress: address => address, - isAddress: () => true, -})); - initDependenciesWithDefaultMocks(); async function mountTokenProvider() { @@ -73,7 +68,8 @@ test('injects veBAL onchain data', async () => { test('injects new tokens', async () => { const { injectTokens, injectedTokens } = await mountTokenProvider(); - await injectTokens(['new token address']); + const newTokenAddress = '0x95ad61b0a150d79219dcf64e1e6cc01f0b64c4ce'; + await injectTokens([newTokenAddress]); expect(injectedTokens.value).toMatchInlineSnapshot(` { @@ -85,8 +81,8 @@ test('injects new tokens', async () => { "name": "mocked onchain token name", "symbol": "mocked onchain token symbol", }, - "new token address": { - "address": "new token address", + "0x95aD61b0a150d79219dCF64E1E6Cc01f0B64C4cE": { + "address": "0x95aD61b0a150d79219dCF64E1E6Cc01f0B64C4cE", "chainId": 5, "decimals": 18, "logoURI": "",