Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for user defined image directories #18

Open
banool opened this issue Sep 22, 2018 · 0 comments
Open

Improve support for user defined image directories #18

banool opened this issue Sep 22, 2018 · 0 comments
Labels
enhancement New feature or request low priority This issue isn't very important

Comments

@banool
Copy link
Owner

banool commented Sep 22, 2018

Currently there is decent support for text files containing links. The support for directories however is pretty rudimentary. You can see this in the getImagePaths function in server.go.

This would probably require research into each popular webserver's directory listing, as well as creating a sane default. As such it'd probably be a high effort low impact change. A way to help with this might be only pulling links from anchor tags that have image extensions, though I've been reluctant to specify a whitelist of image extensions since browsers support so many different types of media files (though it would only have to be what is supported by the img tag). It's also a bad idea if we move into a world with video support (see #17).

@banool banool added enhancement New feature or request low priority This issue isn't very important labels Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority This issue isn't very important
Projects
None yet
Development

No branches or pull requests

1 participant