-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse over an image to see it in its original size #6
Comments
I address this partially in 816d726. The hover works (including any highlighting and other overlays), but there there are two issues:
I'm leaving this issue open for now in case we decide to improve it further, but it works pretty well for now. |
For this and any other setting, there should be a way to turn it off. The best way to do this will be to make the hover variant a class of its own and if the setting is disabled, use the non-hover variant. |
Turns out this doesn't work on all browsers. On chrome this displays weirdly, the z-index isn't doing what it should. |
Also before I would consider this done, there needs to be an option in the settings to disable this behaviour. |
As of 4d8b850 this is mostly done. All of the above issues have been resolved except:
|
The images can be a bit small, this would help with visibility. Most images will be larger than 130px square so in general this would be larger. You'd have to set a cap on how big you blow it up to.
Consider whether it should go back to normal when the cursor moves beyond the edge of the original image or the blown up image. I think the original.
The text was updated successfully, but these errors were encountered: