Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Why using filters when setting Bootstrap classes? #116

Closed
thednp opened this issue Apr 1, 2014 · 3 comments
Closed

[question] Why using filters when setting Bootstrap classes? #116

thednp opened this issue Apr 1, 2014 · 3 comments

Comments

@thednp
Copy link

thednp commented Apr 1, 2014

Why not just create a theme that already have them and minimize the PHP queries?

@bassjobsen
Copy link
Owner

@thednp thanks for your question. I'm interested in all solutions which can make JBST better.

Are you referring to the filters which set:

<div id="content" role="main" class="site-content <?php echo apply_filters('jbstmaingridclass',jbst_content_span()) ?>">

The grid class set the way the grids act responsive. For instance when the xs (extra small) grid will be chosen the grid columns will never be stack and always horizontal. These setting also play in solving issues like #86

Any suggestions are welcome.

@thednp
Copy link
Author

thednp commented Apr 1, 2014

Thanks for reply my fiend, I think I am making a small confusion while checking multiple free themes at the same time.

I've checked Roots as well as Shoestrap (forked from Roots) and other themes and noticed they use alot of filters to change the HTML mark-up. More examples of such filters here:
https://github.com/cassler/WP-Bootstrap-Transformer

About making jamedo more functional and more interesting I would advise using Vafpress Framework over any other, it offers a great deal of features and the development version includes already new features, it's amazing, check it out:
https://github.com/vafour/vafpress-framework

@bassjobsen
Copy link
Owner

I have checked Vafpress Framework. Seems a solid framework. At the moment i don't see much added value in reference to what JBST alsready has to offer. I like the idea of offering the core as a plugin, i wil consider that for the next version of JBST too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants