Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Bootstrap 4 Alpha 6 a variable is not there anymore #4

Open
slakbal opened this issue Feb 23, 2017 · 0 comments
Open

On Bootstrap 4 Alpha 6 a variable is not there anymore #4

slakbal opened this issue Feb 23, 2017 · 0 comments

Comments

@slakbal
Copy link

slakbal commented Feb 23, 2017

Love this little component... on alpha 6 the SASS variable $font-size-root doesn't exist anymore.
Using $font-size-base should also work but in the following calculation you are doing:

CURRENT:

top:(2 * $input-padding-y + $font-size-base*$line-height-base + 2 * $input-btn-border-width/**$font-size-root**) !important;

NEW:

top:(2 * $input-padding-y + $font-size-base*$line-height-base + 2 * **$input-btn-border-width**/**$font-size-base**) !important;

This however creates an error when compiling because $input-btn-border-width is in pixels and $font-size-base is in rem. Which of-course makes the division problematic.

Unfortunately my knowledge of the px : rem ratios in bootstrap is a bit limited. Thought I'd rather ask you what a proper solution is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant