Edge starting at top left corner of nodes

[borishenicker]

Hi,

First thanks for sharing this really nice library !

I've built an app where edges get added automatically when you add a node :

From node 1 you have a menu to add node 2, and the edge is added automatically. To do that I am only adding / removing nodes and edges on / from 2 refs nodes.value and edges.value

I've recently upgraded from 0.4 to the latest 1.15. Before the upgrade the edges where starting at the bottom of the source and ending at the top of the target, but now they seems to start / end at position 0.

I've tried using addNodes / addEdges, adding handles and changing the sourcePosition and targetPosition :

  nodes.value = [
   {
      id: '1',
      type: 'customaction',
      position: { x: 600, y: 100 },
      sourcePosition: Position.Bottom,
      targetPosition: Position.Top,
      class: 'customactionnode-container',
      height: 80,
      width: 150,
    },
    {
      id: '2',
      type: 'customaction',
      position: { x: 600, y: 250 },
      sourcePosition: Position.Bottom,
      targetPosition: Position.Top,
      class: 'customactionnode-container',
      height: 80,
      width: 150,
    },
  ]
  edges.value = [
    {
      id: 'e1-2',
      source: '1',
      target: '2',
      type: 'step',
      class: 'customedge-container',
    },
  ]

If anybody has an idea where this might be coming from.

Many thanks,

[bcakmakoglu]

A codesandbox with a reproduction would be helpful to analyze your case, otherwise it's really difficult to know what is going on :/

[bcakmakoglu]

Though you shouldn't have to change your code, it is a bug and I have opened a PR to fix that.
I will publish it in a couple mins so please install 1.15.4 and keep your code as-is and see if that solves it as well :)

[borishenicker]

I will let you know

[bcakmakoglu]

1.15.4 is published now

[borishenicker]

Many thanks, I don't have the issue anymore in 1.15.4 with width and height properties in the initial node

[bcakmakoglu]

Nice 👍 Thanks for reporting the issue :)