Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct links don't work anymore #171

Open
cs1m0n opened this issue Mar 16, 2023 · 2 comments
Open

Direct links don't work anymore #171

cs1m0n opened this issue Mar 16, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@cs1m0n
Copy link
Member

cs1m0n commented Mar 16, 2023

Functionality implemented here introduces a bug when trying to navigate directly to an article. The route changes automatically to the last visited article.

Reported here and here.

I could reproduce it myself.

One possible solution is to add an additional check before it changes the route, if the url is the homepage, then redirect.

@cs1m0n cs1m0n added the bug Something isn't working label Mar 16, 2023
@cs1m0n cs1m0n changed the title Direct links not accesible Direct links don't work anymore Mar 17, 2023
@cs1m0n
Copy link
Member Author

cs1m0n commented Mar 17, 2023

FYI: I have pushed a quick-fix by commenting out those lines which redirect the user to the cached page.

@Dr-Wade
Copy link
Collaborator

Dr-Wade commented May 10, 2023

The more I think about it, the less I'm convinced that this feature is actually a good idea.
I agree that a way to fix it is to only change the route if going to the homepage in the first place, but I feel this brings some inconsistency... Maybe we can try it out a bit on dev, and see if this makes sense before we push it to prod?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants